Add top-level compile time to @time report (alternative) #39779
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@NHDaly, in thinking about #39760 I wondered if this might be an alternative way to achieve what #37938 is doing?
Opening as a draft given I'm not sure whether it's better!
It only reports top-level compilation time if it exceeds 0.5 seconds, and it's intentionally low-precision, given higher precision would seem odd given the 0.5 second cutoff.
If users are trying to time with
@timeand care about top-level compilation < 0.5 seconds they probably want to be using@btimeanyway.If moved forward, will need working into other timing macros