Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #29100, make fieldnames inferrable #39832

Merged
merged 1 commit into from Mar 1, 2021
Merged

Conversation

JeffBezanson
Copy link
Sponsor Member

This allows us to fully infer the result, but unfortunately a couple of stubborn getfield operations remain.

@JeffBezanson JeffBezanson added the inference Type inference label Feb 26, 2021
@JeffBezanson JeffBezanson merged commit 3d22421 into master Mar 1, 2021
@JeffBezanson JeffBezanson deleted the jb/infer_fieldnames branch March 1, 2021 18:18
@Sacha0
Copy link
Member

Sacha0 commented Mar 1, 2021

Backport candidate or bridge too far? :)

@KristofferC
Copy link
Sponsor Member

KristofferC commented Mar 1, 2021

Way too far for 1.6.0 at least. Could go into 1.6.1 after it's been baking on master for a while if there is a strong need for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inference Type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants