Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cis(A) for matrix A #40194

Merged
merged 3 commits into from
Apr 1, 2021
Merged

Support cis(A) for matrix A #40194

merged 3 commits into from
Apr 1, 2021

Conversation

schneiderfelipe
Copy link
Contributor

This PR defines cis(A) for matrices as suggested here and here by @stevengj.

@dkarrasch dkarrasch added the linear algebra Linear algebra label Mar 26, 2021
@stevengj
Copy link
Member

LGTM other than the comments above.

@schneiderfelipe schneiderfelipe mentioned this pull request Mar 26, 2021
Open
@stevengj
Copy link
Member

Needs NEWS, plus maybe an entry in the doc index for LinearAlgebra?

@simeonschaub simeonschaub added needs news A NEWS entry is required for this change needs compat annotation Add !!! compat "Julia x.y" to the docstring labels Mar 26, 2021
@simeonschaub
Copy link
Member

simeonschaub commented Mar 26, 2021 •
edited
Loading

A compat annotation specifying that this requires 1.7 would be good as well.

@schneiderfelipe
Copy link
Contributor Author

Needs NEWS, plus maybe an entry in the doc index for LinearAlgebra?

A compat annotation specifying that this requires 1.7 would be good as well.

@stevengj @simeonschaub I added both; please let me know if the info is not in the correct place.

stevengj
stevengj reviewed Mar 27, 2021
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@StefanKarpinski StefanKarpinski merged commit 56623b8 into JuliaLang:master Apr 1, 2021
@schneiderfelipe schneiderfelipe deleted the cis-for-matrices branch April 3, 2021 12:31
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@schneiderfelipe @ElOceanografo
Support cis(A) for matrix A (JuliaLang#40194)
917e0f8
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@schneiderfelipe @antoine-levitt
Support cis(A) for matrix A (JuliaLang#40194)
22ce688
@stevengj stevengj mentioned this pull request May 18, 2021
Merged
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@schneiderfelipe @johanmon
Support cis(A) for matrix A (JuliaLang#40194)
6757c93
@stevengj stevengj mentioned this pull request Feb 5, 2022
Closed
@stevengj stevengj mentioned this pull request Jul 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonschaub simeonschaub simeonschaub left review comments

@sethaxen sethaxen sethaxen left review comments

@stevengj stevengj stevengj approved these changes

Assignees
No one assigned
Labels
linear algebra Linear algebra needs compat annotation Add !!! compat "Julia x.y" to the docstring needs news A NEWS entry is required for this change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@schneiderfelipe @stevengj @simeonschaub @sethaxen @StefanKarpinski @dkarrasch