Support cis(A) for matrix A #40194
Merged
Support cis(A) for matrix A #40194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM other than the comments above. |
stevengj
reviewed
Mar 26, 2021
stevengj
reviewed
Mar 26, 2021
Member
|
Needs NEWS, plus maybe an entry in the doc index for LinearAlgebra? |
simeonschaub
added
needs news
Member
|
A compat annotation specifying that this requires 1.7 would be good as well. |
Contributor
Author
@stevengj @simeonschaub I added both; please let me know if the info is not in the correct place. |
stevengj
reviewed
Mar 27, 2021
stevengj
reviewed
Mar 27, 2021
stevengj
reviewed
Mar 27, 2021
stevengj
reviewed
Mar 27, 2021
sethaxen
reviewed
Mar 29, 2021
stevengj
approved these changes
Mar 29, 2021
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines
cis(A)for matrices as suggested here and here by @stevengj.