Skip to content

Conversation

@simeonschaub
Copy link
Member

This is an initial implementation of the solution proposed in
#24990 (comment).
This is only the parser part to that, so it doesn't currently do
anything useful, but I am mainly putting this up so we can run PkgEval
on it to see how breaking this solution would be.

@simeonschaub simeonschaub added parser Language parsing and surface syntax DO NOT MERGE Do not merge this PR! needs pkgeval Tests for all registered packages should be run with this change labels May 18, 2021
@simeonschaub
Copy link
Member Author

Looks like Documenter doesn't like this already

@simeonschaub simeonschaub force-pushed the sds/underscore_lambda branch from 0d0cecf to 267cea1 Compare May 18, 2021 17:51
This is an initial implementation of the solution proposed in
#24990 (comment).
This is only the parser part to that, so it doesn't currently do
anything useful, but I am mainly putting this up so we can run PkgEval
on it to see how breaking this solution would be.
@simeonschaub simeonschaub force-pushed the sds/underscore_lambda branch from 267cea1 to 00732ab Compare May 19, 2021 13:32
@simeonschaub
Copy link
Member Author

@nanosoldier runtests(ALL, vs = ":master")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

@simeonschaub
Copy link
Member Author

991 packages failed tests only on the current version.

GitHub won't even display the file... 😢

@simeonschaub
Copy link
Member Author

It does seem like most failures are coming from transitive dependencies on MacroTools, but this might still be a little bit too breaking. Some initial analysis:

 (945, MacroTools)
 (38, MatchImpl)
 (30, Unknown)
 (28, SyntaxError)
 (6, Match)
 (3, MatchCore)
 (3, PrintingChange)
 (1, CBinding)
 (1, NewExceptionType)
 (1, DocTest)

@simeonschaub simeonschaub added triage This should be discussed on a triage call and removed needs pkgeval Tests for all registered packages should be run with this change labels May 20, 2021
@simeonschaub
Copy link
Member Author

Marking this for triage to decide whether this is the right approach regarding #24990 vs. only implementing that in lowering and if so, whether this has to be considered a breaking change, meaning it will have to wait for 2.0

@vtjnash vtjnash removed the triage This should be discussed on a triage call label Jun 3, 2021
@vtjnash
Copy link
Member

vtjnash commented Jun 3, 2021

Triage said this doesn't appear to really work. We also discussed that there isn't agreement about what rule to use for #24990

@DilumAluthge DilumAluthge deleted the sds/underscore_lambda branch October 26, 2021 23:24
@DilumAluthge DilumAluthge removed the DO NOT MERGE Do not merge this PR! label Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parser Language parsing and surface syntax

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants