Add efficient evalpoly implementation for an AbstractVector of coefficients #45070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luapulu
force-pushed
the
evalpoly-vector
branch
from
b5efb54 to
55a3eaa
Compare
Luapulu
force-pushed
the
evalpoly-vector
branch
from
55a3eaa to
9e7df27
Compare
Author
|
Seems the errors have nothing to do with my changes here, but I'm not sure I'm qualified to rule it out. |
stevengj
reviewed
Apr 25, 2022
stevengj
reviewed
Apr 25, 2022
stevengj
reviewed
Apr 25, 2022
- replace _evalpoly with new version - remove blank lines - deal with case where coefficient vector has length zero - use nicer way to make variable v type stable - add tests for zero length coefficients and evalpoly output type
Author
|
I agree with your comments and made some changes accordingly. |
stevengj
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is about twice as fast as the current implementation for an
AbstractVectorof coefficients. See my benchmarks and a comparison with other implementations here.The implementation works with custom array indices. Because I use
@inbounds, the AbstractVector subtype must, for safety reasons, guarantee that all integer indices greater than or equal tofirstindexand smaller than or equal tolastindexare valid.