make exp nothrow #46238
Merged
make exp nothrow #46238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
approved these changes
Aug 2, 2022
Member
aviatesk
left a comment
aviatesk
left a comment
There was a problem hiding this comment.
Add a test case that shows the improvement.
simeonschaub
reviewed
Aug 3, 2022
aviatesk
reviewed
Aug 3, 2022
Member
aviatesk
left a comment
aviatesk
left a comment
There was a problem hiding this comment.
We generall want to avoid accessing internals of Effects but use high-level queries instead, as the data structure isn't very stable yet.
Member
Author
|
That's not related. That's about getfield analysis of mutable objects. |
Member
|
Oops, my mistake. I had thought the improved |
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
This change allows our compiler to remove dead calls of these math ops. Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com> Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
This change allows our compiler to remove dead calls of these math ops. Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com> Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before it wasn't because the compiler can't prove that the getindex into the table is inbounds.