Skip to content

make exp nothrow #46238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 4, 2022
Merged

make exp nothrow #46238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fa5dd95
make exp nothrow
oscardssmith Aug 2, 2022
c79495e
add tests
oscardssmith Aug 2, 2022
29dac14
fix typo
simeonschaub Aug 3, 2022
6b00bcb
remove accidentally added line.
oscardssmith Aug 3, 2022
f0daacd
fix typo.
oscardssmith Aug 3, 2022
0b433f1
Merge branch 'master' into make-exp-nothrow
aviatesk Aug 3, 2022
7c87aa8
Update test/math.jl
aviatesk Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions base/special/exp.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,12 +175,10 @@ const J_TABLE = (0x0000000000000000, 0xaac00b1afa5abcbe, 0x9b60163da9fb3335, 0xa
0xa66f0f9c1cb64129, 0x93af252b376bba97, 0xacdf3ac948dd7273, 0x99df50765b6e4540, 0x9faf6632798844f8,
0xa12f7bfdad9cbe13, 0xaeef91d802243c88, 0x874fa7c1819e90d8, 0xacdfbdba3692d513, 0x62efd3c22b8f71f1, 0x74afe9d96b2a23d9)

# XXX we want to mark :consistent-cy here so that this function can be concrete-folded,
# because the effect analysis currently can't prove it in the presence of `@inbounds` or
# `:boundscheck`, but still the access to `J_TABLE` is really safe here
Base.@assume_effects :consistent @inline function table_unpack(ind::Int32)
# :nothrow needed since the compiler can't prove `ind` is inbounds.
Base.@assume_effects :nothrow @inline function table_unpack(ind::Int32)
ind = ind & 255 + 1 # 255 == length(J_TABLE) - 1
j = @inbounds J_TABLE[ind]
j = getfield(J_TABLE, ind) # use getfield so the compiler can prove consistent
jU = reinterpret(Float64, JU_CONST | (j&JU_MASK))
jL = reinterpret(Float64, JL_CONST | (j>>8))
return jU, jL
Expand Down
5 changes: 4 additions & 1 deletion test/math.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1461,7 +1461,10 @@ for fn in (:sin, :cos, :tan, :log, :log2, :log10, :log1p, :exponent, :sqrt, :cbr
@test Core.Compiler.is_foldable(eff)
end
end
for T in (Float32, Float64)
for T in (Float16, Float32, Float64)
for f in (exp, exp2, exp10)
@test Core.Compiler.is_removable_if_unused(Base.infer_effects(f, (T,)))
end
@test Core.Compiler.is_foldable(Base.infer_effects(^, (T,Int)))
@test Core.Compiler.is_foldable(Base.infer_effects(^, (T,T)))
end