[Docs] Move scalar setindex! to optional methods of the AbstractArray interface.
#46833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractArrays have never been required to be mutable, and we have many subtypes of
AbstractArrayinBaseandLinearAlgebrathat do not implementsetindex!since they are immutable, or only implement it for a subset of their indices (e.g.CartesianIndices, the various range types,Symmetric,Hermitian,Diagonal, ). There is also a lot of hope and plans for more immutable, dynamic array support from Base, and of course a rich set of immutable arrays out there in the package ecosystem which do not havesetindex!As far as I can tell, it is simply a false characterization of the AbstractArray interface to say that
setindex!is not an optional method.This PR will move the two lines in the red box here to the Optional methods section, between
IndexStyleand thegetindexon non-scalar indices.