improve inlining cost analysis for invoke #47671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
added
the
compiler:optimizer
vchuravy
added
potential benchmark
Member
Author
|
@nanosoldier |
vtjnash
added
merge me
Collaborator
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
Member
Author
|
merge? |
DilumAluthge
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we just assumed that the cost of an
invokewas 20 while it should be much lower for inferred types and much higher for uninferred types. Fixes https://discourse.julialang.org/t/extremely-slow-invoke-when-inlined/90665