improve apply_type_tfunc accuracy in rare case
#49069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the unlikely event this call fails, we can either confidently
conclude the result will always fail and stop inference immediately
there. Or we can at least conclude that the base type is confidently
known, which can potentially improve ml-matches performance later by
excluding Union{} or other subtypes.
aviatesk
approved these changes
Mar 21, 2023
Xnartharax
pushed a commit
to Xnartharax/julia
that referenced
this pull request
Apr 19, 2023
In the unlikely event this call fails, we can either confidently
conclude the result will always fail and stop inference immediately
there. Or we can at least conclude that the base type is confidently
known, which can potentially improve ml-matches performance later by
excluding Union{} or other subtypes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the unlikely event this call fails, we can either confidently conclude the result will always fail and stop inference immediately there. Or we can at least conclude that the base type is confidently known, which can potentially improve ml-matches performance later by excluding Union{} or other subtypes.