-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
less jl_get_global reflection #53250
Conversation
Some minor code codeup, since this is not supported or working.
Except for those used by staticdata, which uses reflection for everything, this removes most of the remaining runtime callbacks, although a couple also exist to `jl_get_module_binding` still as well.
This pr removes some export functions from julia.h, maybe it's worth adding a NEWS? |
We don't have a stable API promise for C code, including exports, so I don't think there is anything NEWS-worthy here; we change exports on every release and that is just what should be expected. |
Isn't the yeild thing important if someone is embedding julia? |
They probably shouldn't call |
Makes sense, that question aside LGTM |
It was removed in PR JuliaLang#53250 but this bit stayed by accident.
It was removed in PR #53250 but this bit stayed by accident.
It was removed in PR #53250 but this bit stayed by accident.
It was removed in PR JuliaLang#53250 but this bit stayed by accident.
The remaining ones I see are
Base.stdout
Base.DL_LOAD_PATH
Core._parse
Base._atexit
Base._postoutput
Core.ARGS
Base._start
Base.Libc.Libdl.dlopen
Base.task_done_hook
Base.wait
Base.CoreLogging.logmsg_shim
__init__
Base.register_root_module
Base.loaded_modules_array
Base.__toplevel__
Base.require
(of these, the
Base.register_root_module
/Base.loaded_modules_array
should probably be moved to C still, since it is a thread-safety issue / data-race / deadlock risk right now)