Skip to content

add public statement to Base.Broadcast #54060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add public statement to Base.Broadcast #54060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2d6c9b
added `public` statement to broadcast.jl
matthias314 Apr 12, 2024
556e17d
do not make `DefaultVectorStyle` and `DefaultMatrixStyle` public
matthias314 Apr 14, 2024
315ea02
updated test for undocumented names
matthias314 Apr 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions base/broadcast.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ using .Base: Indices, OneTo, tail, to_shape, isoperator, promote_typejoin, promo
_msk_end, unsafe_bitgetindex, bitcache_chunks, bitcache_size, dumpbitcache, unalias, negate
import .Base: copy, copyto!, axes
export broadcast, broadcast!, BroadcastStyle, broadcast_axes, broadcastable, dotview, @__dot__, BroadcastFunction
public AbstractArrayStyle, ArrayStyle, Broadcasted, DefaultArrayStyle,
Unknown, Style, combine_axes, combine_styles, flatten, instantiate,
materialize, result_style

## Computing the result's axes: deprecated name
const broadcast_axes = axes
Expand Down
2 changes: 1 addition & 1 deletion test/broadcast.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,7 +1179,7 @@ f51129(v, x) = (1 .- (v ./ x) .^ 2)
@testset "Docstrings" begin
undoc = Docs.undocumented_names(Broadcast)
@test_broken isempty(undoc)
@test undoc == [:dotview]
@test undoc == [:Broadcasted, :Unknown, :dotview]
Copy link
Member

@LilithHafner LilithHafner Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add docstrings instead of adding exceptions to this test.

end

@testset "broadcast for `AbstractArray` without `CartesianIndex` support" begin
Expand Down