Forward aliasing check for ReshapedArrays to the parent
#54168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SubArrays have a specialized aliasing check that uses both the parent and the indices to detect potential overlaps. However, wrappers ofSubArraysuse only thedataids, which is usually determined only by the parent, ignoring the indices. This PR extends the aliasing check to reshaped subarrays as well, by forwarding the check to the parent subarray. This makes the following not allocate:On master:
This PR