WIP workstealing scheduler + refactor for easier experimentation #55542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seelengrab
reviewed
Aug 21, 2024
|
|
||
| mutable struct Node{T} | ||
| const value::Union{T, Nothing} | ||
| @atomic next::Union{Node{T}, Nothing} |
Contributor
There was a problem hiding this comment.
You can make this type stable by having next and prev point to the current node in case there is no next/previous node.
Member
Author
There was a problem hiding this comment.
Oh cool. This will all need some fine comb optimizations for sure.
…ued work. Also add spin master like behaviour
Seelengrab
reviewed
Aug 26, 2024
| const _PADDING_TUPLE = ntuple(zero, 15) | ||
| mutable struct ConcurrentDoublyLinkedList{T} | ||
| @atomic header::Union{Node{T}, Nothing} | ||
| @atomic header::Union{Node{T}, Nothing} # 8 bytes |
Contributor
There was a problem hiding this comment.
4 byte on 32 bit, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently doesn't work. I assume the bug is on the queue because I'm getting task already running errors.