Skip to content

2-arg show for Symmetric/Hermitian and triangular #56013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

2-arg show for Symmetric/Hermitian and triangular #56013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions stdlib/LinearAlgebra/src/symmetric.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,3 +1051,9 @@ function Base.replace_in_print_matrix(A::HermOrSym,i::Integer,j::Integer,s::Abst
inds = A.uplo == 'U' ? ijminmax : reverse(ijminmax)
Base.replace_in_print_matrix(parent(A), inds..., s)
end

function Base.show(io::IO, S::HermOrSym)
print(io, string(nameof(typeof(S))), "(")
@invoke show(io::IO, S::AbstractMatrix)
print(io, ")")
end
7 changes: 7 additions & 0 deletions stdlib/LinearAlgebra/src/triangular.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2986,3 +2986,10 @@ end
# Cube roots of real-valued triangular matrices
cbrt(A::UpperTriangular{T}) where {T<:Real} = UpperTriangular(_cbrt_quasi_triu!(Matrix{T}(A)))
cbrt(A::LowerTriangular{T}) where {T<:Real} = LowerTriangular(_cbrt_quasi_triu!(Matrix{T}(A'))')

# show
function Base.show(io::IO, S::UpperOrLowerTriangular)
print(io, string(nameof(typeof(S))), "(")
@invoke show(io::IO, S::AbstractMatrix)
print(io, ")")
end
8 changes: 8 additions & 0 deletions stdlib/LinearAlgebra/test/symmetric.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1160,4 +1160,12 @@ end
@test symT-s == Array(symT) - Array(s)
end

@testset "show" begin
A = rand(2,2)
H = Hermitian(A)
S = Symmetric(A)
@test sprint(show, H) == "Hermitian([$(H[1,1]) $(H[1,2]); $(H[2,1]) $(H[2,2])])"
@test sprint(show, S) == "Symmetric([$(S[1,1]) $(S[1,2]); $(S[2,1]) $(S[2,2])])"
end

end # module TestSymmetric
6 changes: 4 additions & 2 deletions stdlib/LinearAlgebra/test/triangular.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,8 +851,10 @@ end

# don't access non-structural elements while displaying
M = Matrix{BigFloat}(undef, 2, 2)
@test sprint(show, UpperTriangular(M)) == "BigFloat[#undef #undef; 0.0 #undef]"
@test sprint(show, LowerTriangular(M)) == "BigFloat[#undef 0.0; #undef #undef]"
@test sprint(show, UpperTriangular(M)) == "UpperTriangular(BigFloat[#undef #undef; 0.0 #undef])"
@test sprint(show, LowerTriangular(M)) == "LowerTriangular(BigFloat[#undef 0.0; #undef #undef])"
@test sprint(show, UnitUpperTriangular(M)) == "UnitUpperTriangular(BigFloat[1.0 #undef; 0.0 1.0])"
@test sprint(show, UnitLowerTriangular(M)) == "UnitLowerTriangular(BigFloat[1.0 0.0; #undef 1.0])"
end

@testset "adjoint/transpose triangular/vector multiplication" begin
Expand Down