-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Adding support for MMTk (non-moving immix) #56288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5257d4a to
4621e5c
Compare
d-netto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First review pass.
Will follow-up with more comments soon.
3e68f3c to
6a01c26
Compare
6a01c26 to
bc08a9b
Compare
167c10f to
c6fd2d9
Compare
|
yes, and it also needs the back ticks |
5c7dfd5 to
8edf616
Compare
|
The package evaluation job you requested has completed - no new issues were detected. |
8edf616 to
27c5480
Compare
|
PkgEval came back fully clean. |
|
The package evaluation job you requested has completed - no new issues were detected. |
5644e19 to
4b415c4
Compare
dc9c9c9 to
6eb18d0
Compare
|
LGTM. We should do the MMTK build with Yggy now and open a PR to run a pkgeval on it. |
578e930 to
85d509e
Compare
|
@oscardssmith I've made the changes to the binding, adding the license files and updated the version here. The PR should be ready to merge 👍 |
* Adding makefile support for building with mmtk
85d509e to
ecabd17
Compare
This PR adds the possibility of building/running Julia using MMTk, running non-moving immix.
The binding code (Rust) associated with it is in https://github.com/mmtk/mmtk-julia/tree/upstream-ready/immix. Instructions on how to build/run Julia with MMTk are described in the
READMEfile inside the binding repo.