Skip to content

Conversation

@baggepinnen
Copy link
Contributor

the PR
- JuliaLang#56045

made this argument required for trimming
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would make removing the experimental flag a breaking change. The user needs to pass this flag into the juliac script, not get supplied automatically, to avoid creating a situation where changing the flag is breaking

@fredrikekre
Copy link
Member

But all of juliac is already experimental:

# NOTE: The interface and location of this script are considered unstable/experimental

@JeffBezanson
Copy link
Member

This change is also needed in test/trimming/Makefile.

@vtjnash 's observation is part of why I am not so excited about this use of --experimental; all it does is change the spelling of --trim to --experimental --trim.

@terasakisatoshi
Copy link

If we pass the --experimental option implicitly. Including it in static_call_graph_arg is a good solution to me.

-static_call_graph_arg() = isnothing(trim) ? `` : `--trim=$(trim)``
+static_call_graph_arg() = isnothing(trim) ? `` : `--experimental --trim=$(trim)``

Ref https://github.com/JuliaLang/julia/pull/56654/files

On the other hand, my feelings are the same as @JeffBezanson says.

I am not so excited about this use of --experimental

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants