Update suitesparse to 7.10.1 #57735
Merged
Update suitesparse to 7.10.1 #57735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
building
Member
|
Can you post your errors? |
Member
|
Since no longer in sysimage, it should be a bit better now. How are you invoking the gen script. Make sure to use julia 1.10 or 1.11. But that is messy given that it is all pinned. |
Member
|
FWIW, the changes to anything we use are minimal, so it is quite likely that the PR will work even without updating the wrappers (no guarantee). We do need to regenerate the wrappers along with this bump but there may be some leeway in ordering. |
Contributor
Author
|
Seems to be working indeed :) |
Member
|
Will be simplest to just bump this here and then do a SparseArrays.jl bump immediately after. |
Member
|
Updated the wrapper generation process and new wrappers: JuliaSparse/SparseArrays.jl#608 As you can see in the diff - there is no change in the API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that this PR will not work, if I understand how suitesparse is integrated into julia, because I am missing a PR to update the SparseArrays bindings at https://github.com/JuliaSparse/SparseArrays.jl/tree/main/gen
However, I have not been able to produce that PR: running the
generator.jlgives me all sorts of errors, so probably I am just misunderstanding how it is supposed to work. Help there would be appreciated.