Skip to content

Fix REPL.ends_with_semicolon bug #57974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix REPL.ends_with_semicolon bug #57974

wants to merge 2 commits into from

Conversation

@PallHaraldsson
Copy link
Contributor

@PallHaraldsson PallHaraldsson commented Apr 1, 2025

Fixes #46189

@IanButterworth IanButterworth added the needs tests Unit tests are required for this change label Apr 1, 2025
@PallHaraldsson
Copy link
Contributor Author

PallHaraldsson commented Apr 1, 2025 •
edited
Loading

I debugged this myself and fixed, but DeepSeek AI got me these tests (they were seemingly all correct, I however slightly shortened them), and have now added them (in right even more shorted format not as shown here):

@testset "REPL semicolon detection with transpose" begin
    @test REPL.ends_with_semicolon("W';") == true
    @test REPL.ends_with_semicolon("W'; # comment") == true
    @test REPL.ends_with_semicolon("W'") == false
    @test REPL.ends_with_semicolon("x'") == false
    @test REPL.ends_with_semicolon("'a'") == false
end

I didn't think AI would manage a fix, and it suggested in another line (I believe this is false, but on the path to correct):

# Adjusted regex to avoid matching transpose operator '
            i = findnext(r"\"(?!\"\")|\"\"\"|(?<![A-Za-z0-9_)\]\}])'|`(?!``)|```|#(?!=)|#=", code, pos)

xal-0 added a commit to xal-0/julia that referenced this pull request May 8, 2025
@xal-0 @PallHaraldsson
[REPL] Fix ends_with_semicolon on adjoint operator with comment
d0dd0c6 
Removes yet another ad-hoc lexer from the REPL and replaces it with JuliaSyntax.

Fixes JuliaLang#46189, with tests taken from JuliaLang#57974.

Co-authored-by: Páll Haraldsson <Pall.Haraldsson@gmail.com>
@xal-0 xal-0 mentioned this pull request May 8, 2025
Merged
oscardssmith pushed a commit that referenced this pull request May 9, 2025
@xal-0 @PallHaraldsson
[REPL] Fix ends_with_semicolon on adjoint operator with comment (#58364)
62d3371 
Removes yet another ad-hoc lexer from the REPL and replaces it with
JuliaSyntax.

Fixes #46189, with tests taken from (and superseding) #57974.

Co-authored-by: Páll Haraldsson <Pall.Haraldsson@gmail.com>
@xal-0
Copy link
Member

xal-0 commented May 9, 2025

Closing in favour of #58364. Thanks for writing the tests!

@xal-0 xal-0 closed this May 9, 2025
charleskawczynski pushed a commit to charleskawczynski/julia that referenced this pull request May 12, 2025
@xal-0 @PallHaraldsson @charleskawczynski
[REPL] Fix ends_with_semicolon on adjoint operator with comment (Juli…
ddb8405 
…aLang#58364)

Removes yet another ad-hoc lexer from the REPL and replaces it with
JuliaSyntax.

Fixes JuliaLang#46189, with tests taken from (and superseding) JuliaLang#57974.

Co-authored-by: Páll Haraldsson <Pall.Haraldsson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs tests Unit tests are required for this change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

REPL.ends_with_semicolon broken on adjoint operator with comment

3 participants

@PallHaraldsson @xal-0 @IanButterworth