Use jlutilities mechanism for external package required in test #60232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
force-pushed
the
kf/stdlibdepstestdeps
branch
from
e4aa84d to
350690b
Compare
Otherwise we try to install the Pkg into the stdlib depot, which corrupts state for Pkg tests. If the test is run manually from `Base.runtests` in a deployed setting, it'll be skipped unless manually installed by the user. This matches how Pkg.jl handles this. After this merges, we should tweak CI to pre-install the packages for both this and the Pkg.jl tests. Fixes intermittent failures in #60222
Keno
force-pushed
the
kf/stdlibdepstestdeps
branch
from
350690b to
1ba4996
Compare
IanButterworth
approved these changes
Nov 25, 2025
Member
|
Ah, did I prematurely merge this.. |
Member
Author
|
No, it's expected, we need to fix that in the CI setup |
KristofferC
pushed a commit
that referenced
this pull request
Nov 29, 2025
(cherry picked from commit 4394713)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we try to install the Pkg into the stdlib depot, which corrupts state for Pkg tests. If the test is run manually from
Base.runtestsin a deployed setting, it'll be skipped unless manually installed by the user. This matches how Pkg.jl handles this. After this merges, we should tweak CI to pre-install the packages for both this and the Pkg.jl tests.Fixes intermittent failures in #60222