loading: Delete normpath where possible
#60251
Open
+197
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
force-pushed
the
kf/loadingnonormpath
branch
from
5d65187 to
9e4c09a
Compare
vtjnash
reviewed
Nov 26, 2025
Keno
added a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Nov 26, 2025
7z appears to normalize internally causing it to fail to extract archives that have this pattern. One way to reproduce is to set DEPOT_PATH to a path that has a symlink/.. in the path. We get this wrong in Julia too, c.f. JuliaLang/julia#60251
Keno
force-pushed
the
kf/loadingnonormpath
branch
from
9e4c09a to
d6d6f2d
Compare
Keno
added a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Nov 26, 2025
7z appears to normalize internally causing it to fail to extract archives that have this pattern. One way to reproduce is to set DEPOT_PATH to a path that has a symlink/.. in the path. We get this wrong in Julia too, c.f. JuliaLang/julia#60251
Keno
added a commit
to timholy/Revise.jl
that referenced
this pull request
Nov 26, 2025
Fixes test failures with JuliaLang/julia#60251. Also fixes an unrelated test where Revise was using the wrong PkgId for Core.Compiler (failure not seen on CI, because it's explicitly disabled there).
Keno
added a commit
to timholy/Revise.jl
that referenced
this pull request
Nov 27, 2025
Fixes test failures with JuliaLang/julia#60251. Also fixes an unrelated test where Revise was using the wrong PkgId for Core.Compiler (failure not seen on CI, because it's explicitly disabled there).
Keno
added a commit
to timholy/Revise.jl
that referenced
this pull request
Nov 27, 2025
Fixes test failures with JuliaLang/julia#60251. Also fixes an unrelated test where Revise was using the wrong PkgId for Core.Compiler (failure not seen on CI, because it's explicitly disabled there).
Keno
added a commit
to timholy/Revise.jl
that referenced
this pull request
Nov 27, 2025
* Adjust for base paths possibly being non-normalized Fixes test failures with JuliaLang/julia#60251. Also fixes an unrelated test where Revise was using the wrong PkgId for Core.Compiler (failure not seen on CI, because it's explicitly disabled there). * Try more realpaths * relpath? * WIP * Try to avoid calling realpath internally
Member
Author
|
Alright, we have some tests that specifically test that we strip |
Keno
force-pushed
the
kf/loadingnonormpath
branch
from
770f1e5 to
ff57fe1
Compare
lgoettgens
reviewed
Nov 28, 2025
lgoettgens
reviewed
Nov 28, 2025
KristofferC
pushed a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Nov 28, 2025
7z appears to normalize internally causing it to fail to extract archives that have this pattern. One way to reproduce is to set DEPOT_PATH to a path that has a symlink/.. in the path. We get this wrong in Julia too, c.f. JuliaLang/julia#60251 (cherry picked from commit 52d7fa3)
Keno
force-pushed
the
kf/loadingnonormpath
branch
from
ff57fe1 to
af8a57d
Compare
Unix path semantics have a design flaw, where if `a` is a symbolic directory link, `x/a/..` refer's to the link target's parent directory rather than `x/`. As a result, `normpath` is not in general safe to run. We were doing this all over the place (either explicitly, or implicitly in `abspath`) causing us to fail to load files if their paths contained this pattern. Fix this by rm'ing normpath in most places in loading and adding an `normpath`/`abspath` kwarg that skips unsafe normalization. Where paths show up in printing, we can possibly put some back after verifying that the path resolution result does not change using `samefile`, but let's do that on a case-by-case basis.
Keno
force-pushed
the
kf/loadingnonormpath
branch
from
af8a57d to
f16cf92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unix path semantics have a design flaw, where if
ais a symbolic directory link,x/a/..refer's to the link target's parent directory rather thanx/. As a result,normpathis not in general safe to run. We were doing this all over the place (either explicitly, or implicitly inabspath) causing us to fail to load files if their paths contained this pattern. Fix this by rm'ing normpath in most places in loading and adding anabspathkwarg that skips normalization. Where paths show up in printing, we can possibly put some back after verifying that the path resolution result does not change usingsamefile, but let's do that on a case-by-case basis.