Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Uint => UInt (closes #8905) #8907

Merged
merged 1 commit into from Nov 6, 2014

Conversation

3 participants
@StefanKarpinski
Copy link
Member

commented Nov 5, 2014

No description provided.

@StefanKarpinski

This comment has been minimized.

Copy link
Member Author

commented Nov 5, 2014

This makes concerns about whitespace fixes making merges hard seem completely and utterly silly.

@jakebolewski

This comment has been minimized.

Copy link
Member

commented Nov 5, 2014

Can we have that too? I'll submit a PR if we are being greedy today :-)

@StefanKarpinski

This comment has been minimized.

Copy link
Member Author

commented Nov 5, 2014

Yeah, of course. Not point not doing it now.

@jakebolewski

This comment has been minimized.

Copy link
Member

commented Nov 5, 2014

Ok. After this is merged.

@ivarne

This comment has been minimized.

Copy link
Member

commented Nov 5, 2014

I have a half finished git command to check for whitespace introduced in a PR. This way you would avoid builds from breaking when you you actually didn't introduce any errors.

git diff --check HEAD^1 HEAD^2 -- '*.jl' '*.cpp' '*.scm' '*.h' '*.c'

I'll test it with some different conditions on Travis tomorrow.

StefanKarpinski added a commit that referenced this pull request Nov 6, 2014

Merge pull request #8907 from JuliaLang/sk/UInt
rename Uint => UInt (closes #8905)

@StefanKarpinski StefanKarpinski merged commit cd450f6 into master Nov 6, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

ivarne added a commit to JuliaLang/Compat.jl that referenced this pull request Nov 6, 2014

timholy added a commit to JuliaIO/HDF5.jl that referenced this pull request Nov 15, 2014

@jiahao jiahao deleted the sk/UInt branch Jan 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.