Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate zero and one for Ptr{T} #8909

Merged
merged 1 commit into from Nov 10, 2014

Conversation

2 participants
@ivarne
Copy link
Member

commented Nov 5, 2014

They doesn't fulfill the documentation for zero and one about additive and multiplicative identity.

See discussion in #6183 (comment)

@@ -215,3 +215,8 @@ end

export String
const String = AbstractString

@deprecate zero{T}(::Type{Ptr{T}}) = Ptr{T}(0)

This comment has been minimized.

Copy link
@JeffBezanson

JeffBezanson Nov 5, 2014

Member

You don't want the = here.

This comment has been minimized.

Copy link
@ivarne

ivarne Nov 5, 2014

Author Member

No, I most definitely don't want = there! Thanks and sorry

Deprecate zero and one for Ptr{T}
They doesn't fulfill the documentation for zero and one about additive
and multiplicative identity.

See discussion in
#6183 (comment)

@ivarne ivarne force-pushed the ivarne:one_ptr branch from a3c22f4 to 47348ec Nov 5, 2014

@JeffBezanson JeffBezanson merged commit 47348ec into JuliaLang:master Nov 10, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details

@ivarne ivarne deleted the ivarne:one_ptr branch Nov 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.