Skip to content

Use the published versions.json instead of listing versions in source code? #131

@KristofferC

Description

@KristofferC

Instead of hardcoding version information in the build file:

juliaup/build.rs

Lines 23 to 52 in 623684d

let lts_version = Version::parse("1.0.5")?;
let beta_version = Version::parse("1.7.0-beta3")?;
let rc_version = Version::parse("1.7.0-beta3")?;
original_available_versions.push(Version::parse("0.7.0")?);
original_available_versions.push(Version::parse("1.0.0")?);
original_available_versions.push(Version::parse("1.0.1")?);
original_available_versions.push(Version::parse("1.0.2")?);
original_available_versions.push(Version::parse("1.0.3")?);
original_available_versions.push(Version::parse("1.0.4")?);
original_available_versions.push(Version::parse("1.0.5")?);
original_available_versions.push(Version::parse("1.1.0")?);
original_available_versions.push(Version::parse("1.1.1")?);
original_available_versions.push(Version::parse("1.2.0")?);
original_available_versions.push(Version::parse("1.3.0")?);
original_available_versions.push(Version::parse("1.3.1")?);
original_available_versions.push(Version::parse("1.4.0")?);
original_available_versions.push(Version::parse("1.4.1")?);
original_available_versions.push(Version::parse("1.4.2")?);
original_available_versions.push(Version::parse("1.5.0")?);
original_available_versions.push(Version::parse("1.5.1")?);
original_available_versions.push(Version::parse("1.5.2")?);
original_available_versions.push(Version::parse("1.5.3")?);
original_available_versions.push(Version::parse("1.5.4")?);
original_available_versions.push(Version::parse("1.6.0")?);
original_available_versions.push(Version::parse("1.6.1")?);
original_available_versions.push(Version::parse("1.6.2")?);
original_available_versions.push(Version::parse("1.7.0-beta1")?);
original_available_versions.push(Version::parse("1.7.0-beta2")?);
original_available_versions.push(Version::parse("1.7.0-beta3")?);

it perhaps makes sense to use the published https://julialang-s3.julialang.org/bin/versions.json file (that among other things is used for CI). That would decouple the version information from the juliaup executable which feels like a good idea.

There is, however, no way to determine which is the latest LTS from that file AFAIU. That could be hardcoded to be 1.0.x for now (where the latest such version from the file is used).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions