Avoid recursion in _banded_muladd! for vectors
#293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may avoid recursion in
_banded_muladd!and directly call_banded_gbmv!instead. This makes type-inference easier, and reduces TTFX.On master
This PR
Tests for
BlockBandedMatrices,ApproxFunBase,ApproxFunOrthogonalPolynomialsandApproxFunpass locally for me with this PR. This also resolves the issue with precompilingB * vin #283 (comment)