Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Jul 4, 2023

On master

julia> A = zeros(10,10);

julia> r = first(to_indices(A, (band(1),)));

julia> @btime @inbounds $r[1:end];
  19.346 ns (0 allocations: 0 bytes)

After this PR,

julia> @btime @inbounds $r[1:end];
  13.774 ns (0 allocations: 0 bytes)

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c1582fd) 89.39% compared to head (9aaaab6) 89.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   89.39%   89.39%           
=======================================
  Files          24       24           
  Lines        3479     3479           
=======================================
  Hits         3110     3110           
  Misses        369      369           
Impacted Files Coverage Δ
src/generic/Band.jl 83.95% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit adb2aec into JuliaLinearAlgebra:master Jul 4, 2023
@jishnub jishnub deleted the bandslicepropagateinbounds branch July 4, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant