Should this library be deprecated?

[oscardssmith]

This library has a number of pretty severe bugs and given it's use of DIGITS is incorrect for any large or small numbers (with an exponent of >10 or <-10). As such, it either needs a fairly substantial overhaul or to be deprecated to warn users away from using it.

[barucden]

Not promising anything, but I'd like to devote some time to the library. However, I think some reviewers with merging rights are needed too. There are already a few PRs that seem fine but haven't been merged (or rejected) for months.

[edwloef]

Not promising anything, but I'd like to devote some time to the library. However, I think some reviewers with merging rights are needed too. There are already a few PRs that seem fine but haven't been merged (or rejected) for months.

Maybe you can contact the Julia team directly via e-mail, so that either this package gets more attention or additional maintainers are given merge permissions?

[tinybike]

Hello, I haven't looked at this repo (or even used Julia itself 😢) in ages, but I wanted to chime in and support the idea of giving @barucden merge permissions if he wants to move it forward.

[barucden]

I'd be more comfortable proposing PRs and having someone experienced review & merge them. However, if the current maintainers are busy, I can try and do my best as a maintainer.

[tinybike]

I'm not sure there are current maintainers tbh. I wrote some of the original code a long time ago, but I haven't used Julia in many years and would not feel comfortable reviewing Julia PRs. I think it's fine for you to be a maintainer if you want to be.

Also, just to be clear, I'm not an admin in this group, so you'll have to contact the julia team to get merge permissions!

Edit to add: I'm not an admin, but, it looks like I still have merge permissions myself. So, if it's alright with everyone, I don't mind going ahead and merging in PRs that you think are ready @barucden -- it's probably better than just leaving the library in its current state (i.e. broken). I see there are several open PRs -- just mark any that you think are ready for merging.

[barucden]

Thank you, @tinybike. I created a topic on Discourse but haven't received any response yet. Who is "the julia team"? I see some familiar faces in the list of contributors here, but I am hesitant to start randomly tagging them; especially when I don't know if they are an admin.

[tinybike]

Honestly I don't know. I haven't even used Julia in years. There are several "owners" listed in this group (https://github.com/orgs/JuliaMath/people?page=1) although I'm not sure who it is appropriate to ping about this -- @ViralBShah maybe? (Or if not, maybe he could at least point you in the right direction?)

[ViralBShah]

@barucden I am inviting you to this repo and saying the obvious (hope you don't mind). Please use PRs to update the package, and while ok to merge the maintenance and simple feature+test oriented PRs without review, major changes probably should be.

[ViralBShah]

@tinybike I have given you maintain rights - so that you should be able to invite new contributors. Thanks folks!

[barucden]

Thank you, @ViralBShah.

Please use PRs to update the package, and while ok to merge the maintenance and simple feature+test oriented PRs without review, major changes probably should be.

You are saying that I should have other people review major changes before merging, right? Would you mind me pinging you personally at such PRs? Or could you suggest other reviewers?

[ViralBShah]

I suggest that for major PRs, just give it a few days before merging. Sometimes reviewers have time and bandwidth, and other times they don't - so hard to predict, and it will evolve.