Fix inference for certain hessian BC/NoInterp combinations #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a little unclear why switching from broadcasting to `map` works, but in any case it's easier on the compiler which is a good thing in and of itself.
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
- Coverage 47.98% 47.84% -0.15%
==========================================
Files 21 21
Lines 1044 1045 +1
==========================================
- Hits 501 500 -1
- Misses 543 545 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a little unclear why switching from broadcasting to
mapworks, but in any case it's easier on the compiler which is a good thing in and of itself.@dkarrasch, once this merges you can rebase your branch on master, and I think it should fix the inference problem.