Skip to content

Conversation

@contradict
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #490 (38d58d7) into master (fc3d8d2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #490   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files          27       27           
  Lines        1819     1819           
=======================================
  Hits         1578     1578           
  Misses        241      241           
Impacted Files Coverage Δ
src/scaling/scaling.jl 90.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc3d8d2...38d58d7. Read the comment docs.

@mkitti
Copy link
Collaborator

mkitti commented May 12, 2022

It looks like we are intentionally removing units from coordlookup, is that right?

@contradict
Copy link
Contributor Author

Correct, the output of coordlookup is used to index the UnitRange of the original interpolation object, so it should not have units.

@mkitti mkitti merged commit 35eb371 into JuliaMath:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants