Skip to content

Conversation

@mkitti
Copy link
Collaborator

@mkitti mkitti commented Jul 14, 2022

Specifically, deprecate LinearInterpolation, ConstantInterpolation,
and CubicSplineInterpolation in favor of linear_interpolation,
constant_interpolation, and cubic_spline_interpolation, respectively
since these are merely functions and not types.

Put another way:

julia> Dict([
           :ConstantInterpolation => :constant_interpolation,
           :LinearInterpolation => :linear_interpolation,
           :CubicSplineInterpolation => :cubic_spline_interpolation
       ])
Dict{Symbol, Symbol} with 3 entries:
  :CubicSplineInterpolation => :cubic_spline_interpolation
  :LinearInterpolation      => :linear_interpolation
  :ConstantInterpolation    => :constant_interpolation

Specifically, deprecate LinearInterpolation, ConstantInterpolation,
and CubicSplineInterpolation in favor of linear_interpolation,
constant_interpolation, and cubic_spline_interpolation, respectively
since these are merely functions and not types.
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #501 (e9fe6c7) into master (4bd7af8) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

❗ Current head e9fe6c7 differs from pull request most recent head a4226c0. Consider uploading reports for the commit a4226c0 to get more accurate results

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
- Coverage   87.10%   86.91%   -0.19%     
==========================================
  Files          28       27       -1     
  Lines        1845     1819      -26     
==========================================
- Hits         1607     1581      -26     
  Misses        238      238              
Impacted Files Coverage Δ
src/Interpolations.jl 79.52% <ø> (+3.60%) ⬆️
src/deprecations.jl 2.56% <ø> (ø)
src/iterate.jl 100.00% <ø> (ø)
src/convenience-constructors.jl 100.00% <100.00%> (ø)
src/gridded/gridded.jl 96.82% <0.00%> (-1.59%) ⬇️
src/b-splines/b-splines.jl 90.00% <0.00%> (-0.10%) ⬇️
src/lanczos/lanczos.jl 100.00% <0.00%> (ø)
src/gpu_support.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bd7af8...a4226c0. Read the comment docs.

@mkitti mkitti mentioned this pull request Jul 19, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants