Added spherical bessel functions #196
Conversation
Co-Authored-By: Alex Arslan <ararslan@comcast.net>
|
The values I'm comparing against in the tests come from Mathematica's |
Co-Authored-By: Alex Arslan <ararslan@comcast.net>
ararslan
dismissed
their stale review
I don't know enough about spherical Bessel functions to feel comfortable merging but this looks reasonable to me if Steven agrees.
|
It may be better to not add new functionality to this package and instead build newer packages. This package is largely a wrapper around fortran code. |
|
I disagree, I think this is a fine home for special functions in general. They can be replaced with pure Julia implementations piecemeal and perhaps sometime in the future they'll all be rewritten and we can just drop the binary dependency from this package without a disruption to users. |
|
I agree with Alex. OpenSpecFun can still be useful for testing, but I don't see the need to move elsewhere |
|
I also agree with Alex. This package isn't really a thin wrapper around fortran or openspecfun. I also see no tension between holding both openspec and fortran wrappers in the same package. In the future we can always rewrite functions in pure Julia, given time and effort. It seems too fragmented to split off things into a spererat package. |
|
This PR LGTM, needs a rebase |
|
If someone can resolve the conflict (which I don't quite understand) and tag a new release I think this can be merged. Since this makes new exports I guess it should technically be a minor tag? |
musm
left a comment
musm
left a comment
There was a problem hiding this comment.
this is the patch, not the minor version
|
CI failure appears to be unrelated. |
|
LGTM not 100% on the threshold level, but we can revisit or look into it later in more detail |
| solution to the radial part of the Helmholz equation in spherical coordinates. Sometimes | ||
| known as a spherical Neumann function. | ||
| """ | ||
| sphericalbessely(nu, x::T) where {T} = √((float(T))(π)/2x) * bessely(nu + 1//2, x) |
There was a problem hiding this comment.
8 participants
No description provided.