From 93427cab2ce9e087fbfca386d5c8c5b97ee0caaf Mon Sep 17 00:00:00 2001 From: Keita Nakamura Date: Thu, 24 Oct 2024 21:18:56 +0900 Subject: [PATCH 1/2] Fix 5-argument `boxdot!` --- src/TensorCore.jl | 2 +- test/runtests.jl | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/TensorCore.jl b/src/TensorCore.jl index ea354f6..e274d29 100644 --- a/src/TensorCore.jl +++ b/src/TensorCore.jl @@ -278,7 +278,7 @@ else # For boxdot!, only where mul! behaves differently: boxdot!(Y::AbstractArray, A::AbstractArray, B::AdjOrTransAbsVec, - α::Number=true, β::Number=false) = boxdot!(Y, A, vec(B)) + α::Number=true, β::Number=false) = boxdot!(Y, A, vec(B), α, β) end diff --git a/test/runtests.jl b/test/runtests.jl index 9279090..ce7508f 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -268,6 +268,8 @@ end if VERSION >= v"1.3" @test boxdot!(similar(c), A, c, 100) == A * c * 100 @test boxdot!(copy(c), B, d, 100, -5) == B * d * 100 .- 5 .* c + @test boxdot!(similar(c), A, c', 100) == A * conj(c) * 100 + @test boxdot!(copy(c), B, d', 100, -5) == B * conj(d) * 100 .- 5 .* c end @test boxdot!(similar(c), A, c') == A * conj(c) From 985c24962e589622c74397d9bd55c3204bd97db8 Mon Sep 17 00:00:00 2001 From: Keita Nakamura Date: Thu, 24 Oct 2024 21:19:33 +0900 Subject: [PATCH 2/2] Fix test --- test/runtests.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/runtests.jl b/test/runtests.jl index ce7508f..5657f2f 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -188,7 +188,7 @@ end d = [3im, 4-5im] @test A ⊡ B == A * B - @test A ⊡ c == A ⊡ c + @test A ⊡ c == A * c @test c ⊡ A == vec(transpose(c) * A) @test c ⊡ d == sum(c .* d)