New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building tests on GNU/kFreeBSD and GNU/Hurd #129

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@ginggs
Contributor

ginggs commented Apr 3, 2016

Since 4c8740a -rpath is only set for $(OS) = Linux.
If setting -rpath only breaks OS X, then it may be better to set -rpath everywhere except where $(OS) = Darwin.

@tkelman

This comment has been minimized.

Show comment
Hide comment
@tkelman

tkelman Apr 3, 2016

Contributor

Don't think Windows needs rpath either

Contributor

tkelman commented Apr 3, 2016

Don't think Windows needs rpath either

@ginggs

This comment has been minimized.

Show comment
Hide comment
@ginggs

ginggs Apr 4, 2016

Contributor

@tkelman

Don't think Windows needs rpath either

I agree, but does having -rpath set break the Windows build? I haven't tested that it breaks an OS X build either.

Contributor

ginggs commented Apr 4, 2016

@tkelman

Don't think Windows needs rpath either

I agree, but does having -rpath set break the Windows build? I haven't tested that it breaks an OS X build either.

@tkelman

This comment has been minimized.

Show comment
Hide comment
@tkelman

tkelman Apr 4, 2016

Contributor

Would have to test whether that flag is accepted.

Contributor

tkelman commented Apr 4, 2016

Would have to test whether that flag is accepted.

@cdluminate

This comment has been minimized.

Show comment
Hide comment
@cdluminate
Contributor

cdluminate commented May 26, 2018

@ginggs

This comment has been minimized.

Show comment
Hide comment
@ginggs

ginggs May 26, 2018

Contributor

Fixed in #167.

Contributor

ginggs commented May 26, 2018

Fixed in #167.

@ginggs ginggs closed this May 26, 2018

@ginggs ginggs deleted the ginggs:kfreebsd-hurd-tests branch Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment