Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
First go at flexible SCF convergence criteria #126
I thought about using the callback, but then I figured that the two things are really kind of orthogonal. I guess what one could do is have a list of functions and let each of them update the info (take it, do what you want and return it). If the "converged" flag is set to true by one of them, that means that the iterations are to be stopped. But then you can also quickly add other things to the SCF if you wanted.
Why I did not do that was that if you only want to change the convergence, than
I agree we should have separate callbacks for printing and for stopping. What I really don't like is the mutation (mutation baaaad). How about we just have a stopping criterion that has the form of a callback? Then we can build more sophisticated stuff on top later on if we want to