Skip to content

Conversation

@ederag
Copy link

@ederag ederag commented Aug 3, 2022

Created by PkgTemplate.

This is a first attempt (the CI is not launched for the fork).
If this works, windows and osx should be added.

Hope this will help to unlock the other PRs.

@ederag ederag marked this pull request as draft August 3, 2022 16:17
@ederag
Copy link
Author

ederag commented Aug 10, 2022

Kind ping, @pkofod maybe ?
(no need to review, please just approve the workflow, so that I can polish the PR with test results available)

matrix:
version:
- '1.6'
- '1.7'
Copy link

@thomvet thomvet Aug 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to change '1.7' to '1', so that it will always run on the most current minor release.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks for the review.
1.8 is out, so I'd just add 1, when someone with access enables the workflow :

First-time contributors need a maintainer to approve running workflows

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would if I could! :)

@pkofod
Copy link
Member

pkofod commented Aug 23, 2022

absolutely sorry for dragging my feet. I appreciate the help, but I'm fixing this to get it processed today. Again, sorry.

@pkofod pkofod closed this Aug 23, 2022
@ederag ederag deleted the github_ci branch September 4, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants