Parameterize Constant on the type of its value #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omus
reviewed
Jan 8, 2019
ararslan
force-pushed
the
aa/parametric-constant
branch
from
f565146
to
7e60564
Compare
ararslan
commented
Jan 8, 2019
ararslan
commented
Jan 8, 2019
ararslan
force-pushed
the
aa/parametric-constant
branch
2 times, most recently
from
95d8d73
to
9e14301
Compare
ararslan
commented
Jan 9, 2019
ararslan
force-pushed
the
aa/parametric-constant
branch
2 times, most recently
from
b8c8255
to
96e14cc
Compare
rofinn
reviewed
Jan 18, 2019
oxinabox
reviewed
Jan 18, 2019
This allows for more expressive condition checking using dispatch, as complex numbers, real numbers, or arrays thereof can be handled as separate methods. This also limits the types that can be accepted as constant values to scalars, vectors, and matrices. Previously this was assumed but not actually checked.
ararslan
force-pushed
the
aa/parametric-constant
branch
from
96e14cc
to
9bdc601
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for more expressive condition checking using dispatch, as complex numbers, real numbers, or arrays thereof can be handled as separate methods.
This also limits the types that can be accepted as constant values to scalars, vectors, and matrices. Previously this was assumed but not actually checked.Fixes #264.