Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for solvers that don't support NLP #1997

Merged
merged 1 commit into from Jun 23, 2019

Conversation

@mlubin
Copy link
Member

commented Jun 23, 2019

Fixes #1996

@blegat
blegat approved these changes Jun 23, 2019
@codecov

This comment has been minimized.

Copy link

commented Jun 23, 2019

Codecov Report

Merging #1997 into master will increase coverage by 0.12%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1997      +/-   ##
==========================================
+ Coverage   88.86%   88.98%   +0.12%     
==========================================
  Files          33       33              
  Lines        4283     4287       +4     
==========================================
+ Hits         3806     3815       +9     
+ Misses        477      472       -5
Impacted Files Coverage Δ
src/optimizer_interface.jl 81.81% <80%> (+4.31%) ⬆️
src/nlp.jl 90.26% <0%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf5657a...2581a01. Read the comment docs.

@mlubin mlubin merged commit 4fdad2b into master Jun 23, 2019
4 of 5 checks passed
4 of 5 checks passed
codecov/patch 80% of diff hit (target 88.86%)
Details
codecov/project 88.98% (+0.12%) compared to cf5657a
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mlubin mlubin deleted the ml/1996 branch Jun 23, 2019
dourouc05 added a commit to dourouc05/JuMP.jl that referenced this pull request Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.