Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error message for x.f(y) in NL expressions #2017

Merged
merged 1 commit into from Aug 4, 2019

Conversation

@mlubin
Copy link
Member

commented Aug 3, 2019

Fixes #2016

@codecov

This comment has been minimized.

Copy link

commented Aug 3, 2019

Codecov Report

Merging #2017 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2017      +/-   ##
=========================================
+ Coverage    91.5%   91.5%   +<.01%     
=========================================
  Files          33      33              
  Lines        4212    4215       +3     
=========================================
+ Hits         3854    3857       +3     
  Misses        358     358
Impacted Files Coverage Δ
src/parse_nlp.jl 90.9% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79ffa8...89ed2b2. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Aug 3, 2019

Codecov Report

Merging #2017 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2017      +/-   ##
=========================================
+ Coverage    91.5%   91.5%   +<.01%     
=========================================
  Files          33      33              
  Lines        4212    4215       +3     
=========================================
+ Hits         3854    3857       +3     
  Misses        358     358
Impacted Files Coverage Δ
src/parse_nlp.jl 90.9% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79ffa8...89ed2b2. Read the comment docs.

@odow

odow approved these changes Aug 4, 2019

@blegat

blegat approved these changes Aug 4, 2019

@mlubin mlubin merged commit bca74b7 into master Aug 4, 2019

5 checks passed

codecov/patch 100% of diff hit (target 91.5%)
Details
codecov/project 91.5% (+<.01%) compared to c79ffa8
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mlubin mlubin deleted the ml/2016 branch Aug 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.