Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition from LightGraphs.jl to Graphs.jl #424

Closed
vancleve opened this issue Aug 23, 2022 · 4 comments
Closed

Transition from LightGraphs.jl to Graphs.jl #424

vancleve opened this issue Aug 23, 2022 · 4 comments

Comments

@vancleve
Copy link

It seems like there isn't much code in POMDPs.jl that relies on LightGraphs.jl:

POMDPs.jl/src/gen_impl.jl

Line 78 in c4ce119

dag = SimpleDiGraph(length(depnames))

Maybe this works without modification using the updated Graphs.jl package? Would be nice to move to this since Graphs.jl is the replacement for LightGraphs.jl.
@zsunberg
Copy link
Member

Honestly, this is a leftover artifact from POMDPs.jl v0.8. We should just hardcode it. PR welcome.

@zsunberg
Copy link
Member

Actually, it's not very trivial to do something simpler than a topological sort there. If someone makes a PR to switch to Graphs, I'm happy to accept it.

zsunberg added a commit that referenced this issue Aug 24, 2022
@zsunberg
fix #424
28ee4e4
@zsunberg
Copy link
Member

nvm, this was actually easy to switch

@vancleve
Copy link
Author

cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vancleve @zsunberg