Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listed version of Julia (i.e. 1.3) in Project.toml fails CI #532

Closed
dylan-asmar opened this issue Dec 19, 2023 · 2 comments · Fixed by #535
Closed

Listed version of Julia (i.e. 1.3) in Project.toml fails CI #532

dylan-asmar opened this issue Dec 19, 2023 · 2 comments · Fixed by #535
Assignees
@dylan-asmar

Comments

@dylan-asmar
Copy link
Member

The current compat requirement of Julia is listed as 1.3 in the Project.toml (link). However, this version currently fails: https://github.com/JuliaPOMDP/POMDPs.jl/actions/runs/7256047786

I think we should change the compat requirements to the official LTS version of Julia, which is 1.6 (Long-term support (LTS) release: v1.6.7 (July 19, 2022)) and modify the CI to include this min supported version as well to help us catch these potential issues in the future.

These are simple changes, but wanted the thoughts/opinions of the community.
@mykelk
Copy link
Member

mykelk commented Dec 19, 2023

Yes, I think this is sensible.

@zsunberg
Copy link
Member

Yep, that's a great plan!

@dylan-asmar dylan-asmar linked a pull request Dec 19, 2023 that will close this issue
compat requirements for julia changed to LTS 1.6 #535
Merged
@dylan-asmar dylan-asmar self-assigned this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dylan-asmar dylan-asmar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

compat requirements for julia changed to LTS 1.6 JuliaPOMDP/POMDPs.jl
3 participants
@zsunberg @mykelk @dylan-asmar