Add a dont_dlopen flag to build_tarballs. #1239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents BinaryBuilder from dlopen'ing library products during build, while still having the JLL doing so at run time. This matters for (surprise surprise) CUDA libraries, which commonly depend on
libcuda
, a library that will only be available at run time on a system with the CUDA driver installed. That means we don't want to load this library during the build on Yggdrasil, but we also don't want to setdont_dlopen
on the LibraryProduct because we expectlibcuda.so
to be available while loading the JLL. If it isn't, that's detected byaugment_platform!
, which sets the platform tag so that no artifact will be loaded and no wrapper will be selected (and thus no library will bedlopen
ed).Ref JuliaPackaging/Yggdrasil#5701