Stop compilers from using known unsafe options #610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
commented
Jan 13, 2020
ararslan
reviewed
Jan 13, 2020
simonbyrne
reviewed
Jan 13, 2020
ararslan
reviewed
Jan 13, 2020
giordano
force-pushed
the
Ounsafe-fast
branch
from
84b73f9 to
aaf3716
Compare
For context, it was reported in JuliaCI/BaseBenchmarks.jl#253 that dlopening a library compiled with `-Ofast` caused the denormal mode to be changed. This PR disallows using compiler flags that are known to cause troubles. * Add other unsafe flags suggested by Simon Byrne Co-Authored-By: Alex Arslan <ararslan@comcast.net>
giordano
force-pushed
the
Ounsafe-fast
branch
from
aaf3716 to
538731b
Compare
staticfloat
approved these changes
Jan 15, 2020
|
There are legitimate use cases for Is there a way of stripping the flags in a more selective fashion? |
Member
Author
I don't think we can't really distinguish between compile and linking stage. However, it is possible to allow unsafe flags (although this feature is not documented), if this is necessary and there is the possibility to not break someone else's code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, it was reported in
JuliaCI/BaseBenchmarks.jl#253 that dlopening a library
compiled with
-Ofastcaused the denormal mode to be changed.This PR disallows using compiler flags that are known to cause troubles.