Make BinaryBuilderBase compatible with v1.6 only #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Fine with me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few things broken in BBB with Julia v1.7+. I started fixing them #129, but got stuck in Pkg internals (which I don't think have been ever really fixed). I tried to look again in them today and found there are even more broken things, always because of changes in Pkg internals. Unless someone has the bandwidth to go through all of them now, I think the best thing to do is to simply tell the truth: this package only works in Julia v1.6.
If it's accepted, I'll do a PR in the General registry as well to set the upper bound of compat.