Skip to content

Conversation

@davidanthoff
Copy link
Contributor

I created this "blind", i.e. I haven't run this because it is not clear to me what version of BinaryBuilder.jl one should use at this point, plus I don't have a working linux system :)

The overall strategy here was suggested by @giordano.

@giordano
Copy link
Member

giordano commented Oct 6, 2019

It's a bit annoying that these sources (except for the macOS one) are tarbombs that would explode in the same place if used together. I had the same problem with git (#93).

@staticfloat can we be smart when unpacking the source and if it's a tarbomb open it a safer way? On my computer I use ark:

ark -ab tarbomb.tar.gz

would create a top-level directory if the archive doesn't have one, using the base name of the archive. It also automatically guesses the format of the archive, I find it pretty cool. However, I see that ark is not available in repositories of Alpine Linux v3.9 (it's in edge though). Any other option? Like, using tar -t to list the content of the archive?

@staticfloat
Copy link
Member

We actually don't use BB tools to do the unpacking, because of disk performance issues on QEMU. That might be changed when I rebuild the QEMU runner this week (since we're trying to use VirtIO instead of plan9 filesharing) so in that case, we may be able to use whatever tools we want, instead of relying on the host tools.

I also would kind of like a more stable unpacking experience, the exploding is quite annoying.

# Bash recipe for installing on Windows
script = raw"""
cd $WORKSPACE/srcdir/
mkdir ${bindir}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like:

mkdir -p ${bindir} ${libdir}
mv *.${dlext} ${libdir}
mv * ${bindir}

?

This should be improved, though. And the license file installed with install_license.

@IanButterworth
Copy link
Member

Can we resurrect this? The version of Electron provided by Electron.jl is broken on ubuntu 22.04, and lacks M1 support

@IanButterworth IanButterworth mentioned this pull request May 25, 2022
2 tasks
@imciner2
Copy link
Member

imciner2 commented Apr 3, 2024

Closing due to inactivity. Please submit a new PR on top of the current master branch if you still want to include this recipe.

@imciner2 imciner2 closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants