-
Notifications
You must be signed in to change notification settings - Fork 645
[pandoc_crossref] Compat change requires version bump #8896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
One alternative I could see is to translate the pandoc-crossref version and include all of the 4th digit in the patch version:
I don't think the registry tests will like this though as the version number is non-incrementing. There may be a special case for JLLs though. |
|
Hold off on merging this until we settle on a convention |
|
I couldn't remember if we could use non-sequential version numbers with JLL packages and the answer is yes: |
|
Looking at the version history of pandoc-crossref, it looks like it uses zerover with the schema Here are a few examples:
|
|
Do we have evidence that pandoc-crossref is using 0ver? From this comment it seems like the package may be using Haskell PvP I also found this Haskell release of pandoc-crossref which seems to drop the letter from the version: https://hackage.haskell.org/package/pandoc-crossref |
|
The letter is the build -- no real source change, it just reflects which version of pandoc it was compiled against, which is why for haskell sources it doesn't show up. I think Haskell PvP is perhaps the better description. Haskell PvP is a lot like SemVer, but one key difference is that it has |
|
To full incorporate the two |
|
Some examples of the current JLL version created from the pandoc-crossref version: julia> pandoc_crossref_jll_version("0.3.17.0")
v"3.17.0"
julia> pandoc_crossref_jll_version("0.3.17.0f")
v"3.17.6"
julia> pandoc_crossref_jll_version("0.3.17.1")
v"3.17.10"
julia> pandoc_crossref_jll_version("0.3.17.1a")
v"3.17.11"
julia> pandoc_crossref_jll_version("0.3.16.0")
v"3.16.0"
julia> pandoc_crossref_jll_version("0.3.16.0a")
v"3.16.1"
julia> pandoc_crossref_jll_version("1.3.4.5")
v"103.4.50" |
|
Updated examples: julia> pandoc_crossref_jll_version("0.3.17.0")
v"3.17.0"
julia> pandoc_crossref_jll_version("0.3.17.0f")
v"3.17.6"
julia> pandoc_crossref_jll_version("0.3.17.1")
v"3.17.100"
julia> pandoc_crossref_jll_version("0.3.17.1a")
v"3.17.101"
julia> pandoc_crossref_jll_version("0.3.16.0")
v"3.16.0"
julia> pandoc_crossref_jll_version("0.3.16.0a")
v"3.16.1"
julia> pandoc_crossref_jll_version("1.3.4.5")
v"103.4.500" |
* [pandoc_crossref] Compat change requires version bump * Dynamically create JLL version * Support build letters beyond `i`
Follow up to: #8892 (comment)