Threading trick! #113
Merged
Threading trick! #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Spawn `Threads.@Spawn f(x...)` instead of `f(x...)` where `x` is the "fetched" data. 2. repeat every process as many times as nthreads() -- causing Dagger to oversubscribe each worker processors as many times as the threads. TOOD: actually get nthreads from each worker rather than using the value on the master process
jpsamaroo
force-pushed
the
s/threads
branch
from
ae0cd6d
to
440ec7d
Compare
Add options field to Context and set it in scheduler Pass Thunk options down to do_task
jpsamaroo
force-pushed
the
s/threads
branch
from
440ec7d
to
01c8a35
Compare
|
The nightly failure is probably related to Julia not being run with threads; I'll have to figure out how to enable JULIA_NUM_THREADS on CI, or failing that, disable or neuter the threading tests... |
tanmaykm
approved these changes
Sep 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Threads.@spawn f(x...)instead off(x...)wherexis the "fetched" data.By @shashi
Will need to be adjusted so that pre-MT julia still works, and to make this an opt-in feature for now.