Skip to content

document how to pass MPI.Comm objects to C #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 1, 2023
Merged

document how to pass MPI.Comm objects to C #626

merged 5 commits into from
Jan 1, 2023

Conversation

@stevengj
Copy link
Contributor

@stevengj stevengj commented Sep 11, 2022

This seems to be missing from the docs (discourse).

@stevengj
Copy link
Contributor Author

stevengj commented Sep 11, 2022

CI failure LoadError: UndefVarError: get_default_queue not defined seems unrelated.

@giordano
Copy link
Member

giordano commented Sep 11, 2022

Yes. For the record, that's in AMDGPU tests CC @luraess

simonbyrne
simonbyrne reviewed Sep 11, 2022
View reviewed changes
@luraess
Copy link
Contributor

luraess commented Sep 12, 2022 •
edited
Loading

Yes. For the record, that's in AMDGPU tests CC @luraess

Yes, there is an issue related to renaming of AMDGPU.get_default_queue() that leads to CI failure. I'll fix it.

@luraess luraess mentioned this pull request Sep 13, 2022
Merged
@stevengj @simonbyrne
Update docs/src/reference/comm.md
b238455 
Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
@stevengj
Copy link
Contributor Author

stevengj commented Dec 31, 2022

Committed suggestion from @simonbyrne.

simonbyrne
simonbyrne reviewed Jan 1, 2023
View reviewed changes
@simonbyrne simonbyrne merged commit 6f05aa1 into master Jan 1, 2023
@simonbyrne simonbyrne deleted the stevengj-patch-1 branch January 1, 2023 03:16
@simonbyrne
Copy link
Member

simonbyrne commented Jan 1, 2023

Thanks!

@simonbyrne simonbyrne mentioned this pull request Jan 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonbyrne simonbyrne simonbyrne left review comments

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stevengj @giordano @luraess @simonbyrne