Skip to content
This repository was archived by the owner on Jul 13, 2021. It is now read-only.

Merge Makielayout with git history #449

Merged
merged 487 commits into from
Jun 10, 2020
Merged

Merge Makielayout with git history #449

merged 487 commits into from
Jun 10, 2020

Conversation

@SimonDanisch
Copy link
Member

@SimonDanisch SimonDanisch commented Jun 4, 2020

No description provided.

@jkrumbiegel
put layoutnodes into gridlayout
2de9119
@jkrumbiegel
solve and applylayout is now just align_to_bbox!
4ec33c9
@jkrumbiegel
better printing of gridlayout
7062888
@jkrumbiegel
SpannedLayout to GridContent, move functions to gridlayout.jl
4f38553
@jkrumbiegel
extract content returns only array
9c52172
@jkrumbiegel
change updates of gridcontent
a61c9a6
@jkrumbiegel
add attrs to gridlayout, always require autosize node, but with optio…
5c7708a 
…nal floats
@jkrumbiegel
add autosizenodes to all lobjects
d211cbd
@jkrumbiegel
fix typos
ba6a28c
@jkrumbiegel
remove gridlayout parent, instead give layoutnodes a gridcontent with…
388c6e4 
… parent
@jkrumbiegel
add autosizenode to layoutnodes (for debugging mostly)
2aa6c04
@jkrumbiegel
don't block finalbbox updates anymore
d110593
@jkrumbiegel
correct align_to_bbox! for gridlayout, connect with suggestedbbox
bebb15d
@jkrumbiegel
remove commented out
1b06ab9
@jkrumbiegel
new functions to connect and disconnect gridcontent
93198e8
@jkrumbiegel
add trim! function
f6d05a6
@jkrumbiegel
fix deleterow / col bug
e2fd699
@jkrumbiegel
remove unnecessary extra determinedirsize for gridlayouts that was ca…
b016f7e 
…using bugs
@jkrumbiegel
make button auto sized by default
6d918ab
@jkrumbiegel
remove old printlns
886aa62
@jkrumbiegel
fix bbox argument in legend
ecdf565
@jkrumbiegel
enable broadcast for layoutables
5fc8098
@jkrumbiegel
fix legend with new delete functionality
9eb8404
@jkrumbiegel
fix bug
37daa96
@jkrumbiegel
add gridapi.jl
1ec2be7
@jkrumbiegel
improve docstrings
2c7a10a
@jkrumbiegel
remove unnecessary detach from gridnest
fd1d150
@jkrumbiegel
add GridLayout constructor with scene as first argument
13745d0
@jkrumbiegel
fix typo
64baf62
@jkrumbiegel
fix slider autosize
476f6cd
jkrumbiegel and others added 20 commits May 4, 2020 16:18
@jkrumbiegel
fix bug with default theme
6baae28
@jkrumbiegel
forward tickwidth
85e8da9
@jkrumbiegel
fix issue #69
888d153
Tick label colors added
02dce53
@jkrumbiegel
add colorbar ticklabelcolor
ddf5bdf
@jkrumbiegel
move code necessary for rowgap / colgap theming into __init__
745d607 
this didn't work during compilation
@jkrumbiegel
add convenience functions to change LAxis axes positions
9ce177c 
fix
@jkrumbiegel
add labelslider! convenience function
f206950
@jkrumbiegel
export addmousestate!
104f00c
@jkrumbiegel
document mousestate and addmousestate!
27f3c7f
@jkrumbiegel
document tightlimits!
e223a1f
@jkrumbiegel
add docs to xaxis_top etc
a76d836
@jkrumbiegel
remove unused functions
f9853f1
@jkrumbiegel
add docstrings for linkaxes, autolimits!, and limits!
0998423
@jkrumbiegel
specify slider marker for cairomakie compat
71bb394
@SimonDanisch
move to subdirectory
9d2af35
@SimonDanisch
Merge MakieLayout into AbstractPlotting
005d52e
@SimonDanisch
merge makielayout with git history
836bd75
@SimonDanisch
minor refactor
4e9307e
@SimonDanisch
Merge branch 'master' into sd/makielayout_history
595251a
@SimonDanisch
Copy link
Member Author

SimonDanisch commented Jun 5, 2020 •
edited
Loading

Todos:

  • include MakieLayout tests
  • merge documentation
  • update license file
  • assure that @jkrumbiegel authorship isn't lost

@jkrumbiegel
Copy link
Member

jkrumbiegel commented Jun 6, 2020 •
edited
Loading

include MakieLayout tests

MakieLayout doesn't really have tests, the only tests check that the constructors of the different layoutables don't outright fail when called. That at least ensures that the observable pipelines inside didn't get messed up, so I get quite a lot of code coverage just by those couple of lines. I never had time to implement visual checks.

The tests of the layouting functionality live in GridLayoutBase.jl, that package at least is pretty well covered by tests.

@SimonDanisch SimonDanisch merged commit fcba06c into master Jun 10, 2020
@SimonDanisch SimonDanisch deleted the sd/makielayout_history branch June 10, 2020 09:18
@asinghvi17
Copy link
Member

asinghvi17 commented Jun 10, 2020

Nice! We should make an announcement in the slack channel!

@SimonDanisch
Copy link
Member Author

SimonDanisch commented Jun 10, 2020

Well, I think we should clean up the tests a bit first and then tag ;)

@visr visr mentioned this pull request Oct 18, 2020
Merged
@SimonDanisch SimonDanisch mentioned this pull request Jul 29, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SimonDanisch @jkrumbiegel @asinghvi17