annotate! with splatted arguments does not work

[harryscholes]

According to:

Plots.jl/src/shorthands.jl

Line 440 in bfafe91

annotate!(anns...; kw...) = plot!(; annotation = anns, kw...)

I would expect the following to work:

julia> using Plots

julia> plot(1:10)

julia> annotate!((7,3,"(7,3)"), (3,7,text("hey", 14, :left, :top, :green)))
ERROR: MethodError: no method matching process_annotation(::Plots.Subplot{Plots.GRBackend}, ::Tuple{Int64,Int64,String}, ::Tuple{Int64,Int64,Plots.PlotText})
Closest candidates are:
  process_annotation(::Plots.Subplot, ::Any, ::Any, ::Any) at /Users/harry/.julia/packages/Plots/FQOz1/src/components.jl:592
  process_annotation(::Plots.Subplot, ::Any, ::Any, ::Any, ::Any) at /Users/harry/.julia/packages/Plots/FQOz1/src/components.jl:592
  process_annotation(::Plots.Subplot, ::Union{AbstractArray{Symbol,1}, Symbol}, ::Any) at /Users/harry/.julia/packages/Plots/FQOz1/src/components.jl:606
  ...
Stacktrace:
 [1] _update_subplot_periphery(::Plots.Subplot{Plots.GRBackend}, ::Array{Any,1}) at /Users/harry/.julia/packages/Plots/FQOz1/src/args.jl:1399
 [2] _update_subplot_args(::Plots.Plot{Plots.GRBackend}, ::Plots.Subplot{Plots.GRBackend}, ::Dict{Symbol,Any}, ::Int64, ::Bool) at /Users/harry/.julia/packages/Plots/FQOz1/src/args.jl:1502
 [3] _subplot_setup(::Plots.Plot{Plots.GRBackend}, ::Dict{Symbol,Any}, ::Array{Dict{Symbol,Any},1}) at /Users/harry/.julia/packages/Plots/FQOz1/src/pipeline.jl:297
 [4] _plot!(::Plots.Plot{Plots.GRBackend}, ::Dict{Symbol,Any}, ::Tuple{}) at /Users/harry/.julia/packages/Plots/FQOz1/src/plot.jl:206
 [5] #plot!#138(::Base.Iterators.Pairs{Symbol,Tuple{Tuple{Int64,Int64,String},Tuple{Int64,Int64,Plots.PlotText}},Tuple{Symbol},NamedTuple{(:annotation,),Tuple{Tuple{Tuple{Int64,Int64,String},Tuple{Int64,Int64,Plots.PlotText}}}}}, ::typeof(plot!), ::Plots.Plot{Plots.GRBackend}) at /Users/harry/.julia/packages/Plots/FQOz1/src/plot.jl:158
 [6] (::RecipesBase.var"#kw##plot!")(::NamedTuple{(:annotation,),Tuple{Tuple{Tuple{Int64,Int64,String},Tuple{Int64,Int64,Plots.PlotText}}}}, ::typeof(plot!), ::Plots.Plot{Plots.GRBackend}) at ./none:0
 [7] #plot!#137(::Base.Iterators.Pairs{Symbol,Tuple{Tuple{Int64,Int64,String},Tuple{Int64,Int64,Plots.PlotText}},Tuple{Symbol},NamedTuple{(:annotation,),Tuple{Tuple{Tuple{Int64,Int64,String},Tuple{Int64,Int64,Plots.PlotText}}}}}, ::typeof(plot!)) at /Users/harry/.julia/packages/Plots/FQOz1/src/plot.jl:150
 [8] (::RecipesBase.var"#kw##plot!")(::NamedTuple{(:annotation,),Tuple{Tuple{Tuple{Int64,Int64,String},Tuple{Int64,Int64,Plots.PlotText}}}}, ::typeof(plot!)) at ./none:0
 [9] #annotate!#443 at /Users/harry/.julia/packages/Plots/FQOz1/src/shorthands.jl:440 [inlined]
 [10] annotate!(::Tuple{Int64,Int64,String}, ::Tuple{Int64,Int64,Plots.PlotText}) at /Users/harry/.julia/packages/Plots/FQOz1/src/shorthands.jl:440
 [11] top-level scope at none:0

I can't figure out why this doesn't work from the code in shorthands.jl though.

#2485

[BeastyBlacksmith]

What would you expect as output?

[BeastyBlacksmith]

This should work:

julia> using Plots

julia> plot(1:10)

julia> annotate!([(7,3,"(7,3)"), (3,7,text("hey", 14, :left, :top, :green))])

[BeastyBlacksmith]

I think I understand now. The problem is that the slurping collects into a Tuple, but the method expects an AbstractArray.

[harryscholes]

Ah yes you're right. That's it

[harryscholes]

Just noting this here, but I feel like annotate! should work on a single annotation, such as annotate!((7,3,"(7,3)"))

[harryscholes]

Or even annotate!(x, y, text)

[BeastyBlacksmith]

Or even annotate!(x, y, text)

That does work for me

[harryscholes]

Apols, you're right. There were lots of odd things going on for me since I upgraded to 1.4. It's now working