add the plot_title #2690
add the plot_title #2690
Conversation
|
@BeastyBlacksmith, I'm on this.
This is fixed by changing to non-zero heights: |
|
This is not working yet: plot(
(plot(rand(3), legend=:none) for _ ∈ 1:7)...,
layout=(@layout [_ ° _; ° ° °; ° ° °]), plot_title="Complex layout"
)But this is: plot(rand(2), plot_title="Simple layout") |
|
what about |
|
don't forget to rebase this on master |
With the PRs in https://github.com/t-bltg/Plots.jl/commits/bbs/plot_title: using Plots; gr()
using Random; Random.seed!(1234)
main() = begin
plot(
(plot(rand(3), legend=:none) for _ ∈ 1:7)...,
layout=(@layout [_ ° _; ° ° °; ° ° °]), plot_title="Complex layout"
)
plot(rand(3), plot_title="Simple layout")
plot(rand(4, 2), layout=2, plot_title="Very nice layout")
end
main()
I have troubles with my PRs in this branch :(, can't seem to track Do you know maybe how the commits in my fork https://github.com/t-bltg/Plots.jl/commits/bbs/plot_title can land here ? |
|
you can open a PR against this branch |
Not everything can be solved with the command line ;) Not sure if #3604 is what you meant ? |
BeastyBlacksmith
force-pushed
the
bbs/plot_title
branch
from
26ad869 to
463f115
Compare
* add the plot_title * update plot_title for multiple subplots, fix GR warning Co-authored-by: Simon Christ <SimonChrist@gmx.de> Co-authored-by: t-bltg <t-bltg@users.noreply.github.com>
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
|
Can you test if |
|
|
Check out the tests in #3602 |
Seems to work on my machine though. |
Maybe a mixup between my patches & branches ... I'll try to add non-reg tests now. |
|
Also this errors on the pgfplotsx backend with |
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
Ok, my bad, it works: |
Changing the Works with |
|
It'll be great to be able to reduce the amount of white space under the title, I find it too much. |
|
Are there other alternatives to using a super [2, 1] layout ? |
|
The alternative is to pass it to the backends and find ways in each backend to do this. But I'd rather add a case in pgfplotsx to not create an |
I agree, better go in the second direction, modifying |
|
It seems impossible to skip the axis creation: Plots.jl/src/backends/pgfplotsx.jl Line 143 in 0ca5bc9 |
|
I'll do this nxt week don't worry |
* add the plot_title * update plot_title for multiple subplots, fix GR warning * update plot_title * consistency with _subplot_defaults Co-authored-by: Simon Christ <SimonChrist@gmx.de> Co-authored-by: t-bltg <t-bltg@users.noreply.github.com>
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
Codecov Report
@@ Coverage Diff @@
## master #2690 +/- ##
==========================================
+ Coverage 65.09% 65.31% +0.22%
==========================================
Files 27 27
Lines 6660 6688 +28
==========================================
+ Hits 4335 4368 +33
+ Misses 2325 2320 -5
Continue to review full report at Codecov.
|
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
|
@isentropic do you know why it doesn't work with pyplot? |
|
I'm all in for merging this 💯 . |
Fix: #2587
Its a start..
Upon saving, I get
File is written though:
